Author: brianna.laugher

Description:
Hi,

I have a feeling that this used to be fixed, but in recent weeks or months it seems to have reverted.

If you upload a file with a destination filename "Test name with spaces.png", and don't tick "ignore all warnings", you get this warning:

File name has been changed to "Test_name_with_spaces.png".

This warning is basically pointless and just encourages people to tick "ignore all warnings".

in SpecialUpload.php there is

global $wgCapitalLinks;
if( $wgCapitalLinks ) {
    $filtered = ucfirst( $filtered );
}
if( $basename != $filtered ) {
    $warning .=  '<li>'.wfMsgHtml( 'badfilename', htmlspecialchars( $this->mDestName ) ).'</li>';
}

should probably add something like

$filteredunderscores = str_replace(" ","_",$filtered);

and compare $basename to $filteredunderscores instead of $filtered.

Version: unspecified
Severity: enhancement