Page MenuHomePhabricator

VisualEditor: Undo/redo doesn't go through dm.Surface.change() code path
Closed, ResolvedPublic

Description

dm.Surface.undo() and .redo() just call documentModel.rollback() / .commit() directly, without going through all the other stuff in .change() . Presumably this other stuff is useful, so we should figure out if bypassing it causes bugs.


Version: unspecified
Severity: normal

Details

Reference
bz53224

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:10 AM
bzimport set Reference to bz53224.

In theory Surface.change() should also have a corresponding Surface.unchange() method (or a 'reversed' parameter).

Change 88728 had a related patch set uploaded by Catrope:
Implement ve.dm.Surface.prototype.undo() and redo() in terms of change()

https://gerrit.wikimedia.org/r/88728

Change 88728 merged by jenkins-bot:
Implement ve.dm.Surface.prototype.undo() and redo() in terms of change()

https://gerrit.wikimedia.org/r/88728