Page MenuHomePhabricator
Create Task
Maniphest T65873

Upgrade to Moment.js 2.6.0
Closed, ResolvedPublic
Actions

Description

Please upgrade Moment.js to version 2.6.0, which has many bug fixes and several new features. In particular, Moment.js was using an incorrect language code for Vietnamese (vn instead of vi); upgrading should fix the issue in which Hovercards were showing timestamps like “Sửa đổi lần cuối 9 days ago”.

As a side note, it needs to be easier for MediaWiki’s very thorough translators to find out that timestamps are being translated in an obscure third-party project on GitHub.

Version: unspecified
Severity: enhancement
URL: https://github.com/moment/moment/pull/1556

Details

Reference
bz63873

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:20 AM
• bzimport added projects: MediaWiki-JavaScript, I18n.
• bzimport set Reference to bz63873.
• bzimport added a subscriber: Unknown Object (MLST).
mxn created this task.Apr 13 2014, 7:42 AM
Nemo_bis added a comment.Apr 13 2014, 5:26 PM

(In reply to Minh Nguyễn from comment #0)

As a side note, it needs to be easier for MediaWiki’s very thorough
translators to find out that timestamps are being translated in an obscure
third-party project on GitHub.

Ugh. Yet another one? :< Please file a separate bug for that.

Quiddity added a comment.Apr 15 2014, 10:29 PM

(In reply to Nemo from comment #1)

(In reply to Minh Nguyễn from comment #0)

As a side note, it needs to be easier for MediaWiki’s very thorough
translators to find out that timestamps are being translated in an obscure
third-party project on GitHub.

Ugh. Yet another one? :< Please file a separate bug for that.

Prateek, you may want to see [[mw:Extension:CLDR]] - I believe that's what everything else in MediaWiki uses, for timestamps. (Obligatory IANAD disclaimer :)

yuvipanda added a comment.Apr 15 2014, 10:31 PM

moment.js is part of core, so changing component.

yuvipanda added a comment.Apr 15 2014, 10:32 PM

(In reply to Quiddity from comment #2)

Prateek, you may want to see [[mw:Extension:CLDR]] - I believe that's what
everything else in MediaWiki uses, for timestamps. (Obligatory IANAD
disclaimer :)

Sadly there is no way to access CLDR in JS, so moment.js was merged to make up for that.

Tgr added a comment.Apr 15 2014, 11:05 PM

Changelog for 2.6.0 is at https://gist.github.com/ichernev/10544682 , none of it seems to be a breaking change.

gerritbot added a comment.Apr 16 2014, 12:58 PM

Change 126236 had a related patch set uploaded by Prtksxna:
Update moment.js to 2.6.0

https://gerrit.wikimedia.org/r/126236

gerritbot added a comment.Apr 16 2014, 2:07 PM

Change 126236 had a related patch set uploaded by Siebrand:
Update moment.js to 2.6.0

https://gerrit.wikimedia.org/r/126236

gerritbot added a comment.Apr 17 2014, 2:47 PM

Change 126236 merged by jenkins-bot:
Update moment.js to 2.6.0

https://gerrit.wikimedia.org/r/126236

• Phabricator_maintenance removed a subscriber: yuvipanda.Jun 7 2017, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits