Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A method to delete accounts #574

Open
wu-s-john opened this issue Sep 6, 2018 · 5 comments
Open

A method to delete accounts #574

wu-s-john opened this issue Sep 6, 2018 · 5 comments
Assignees
@rbonichon
Labels
planning-for-testnet Issues that should be closed prior to test net launch priority-critical Critical issues that we should look at before any major event stale triage

Comments

@wu-s-john
Copy link
Contributor

We need a way to remove accounts so that an attacker does not flood the database with stale accounts. Previously, we removed accounts if their balance is assigned to zero. However, this is not convenient for the user.
@wu-s-john wu-s-john added planning-for-testnet Issues that should be closed prior to test net launch priority-critical Critical issues that we should look at before any major event labels Sep 6, 2018
@imeckler
Copy link
Member

It's not that it's just inconvenient for the user, the way we were doing it was unsafe and potentially made replaying transactions possible. We will have to think through more deeply a safe way of accomplishing it.

@emberian emberian mentioned this issue Jul 25, 2019
Closed
@emberian
Copy link
Contributor

@imeckler I think we discussed some sort of "replacement" transaction that, if an account has zero (or negligible) balance, lets us install a new public key into that index (but not resetting the nonce). I'm still a bit leery of this- it basically turns into a minimum deposit to hold an account, else some cowboy can kick you out of the ledger.

@shimkiv shimkiv added the triage label Jul 14, 2022
@shimkiv
Copy link
Member

shimkiv commented Jul 18, 2022

Currently we have the deleteAccount daemon's GraphQL Mutation.
Hope it helps. Closing.

@shimkiv shimkiv closed this as completed Jul 18, 2022
@emberian emberian reopened this Jan 12, 2024
@emberian
Copy link
Contributor

That's unrelated, this is about reusing space in the merkle tree.

@submarinec94
Copy link

related but just old issue for reference, once account deletes is done, this can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rbonichon rbonichon

Labels
planning-for-testnet Issues that should be closed prior to test net launch priority-critical Critical issues that we should look at before any major event stale triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@emberian @joseandro @imeckler @shimkiv @rbonichon @wu-s-john @submarinec94