Doesn't support hinting

[matanbanin]

Which is pretty crucial on a wrap of an object, i couldn't use it that way...

[cbefus]

Type hinting was introduced in python 3.5 and continues to evolve. Due to our goal of supporting as many python versions as possible, type hinting has taken a backseat. We will continue to watch for a way to backport type hints of generics through all supported versions of python and reevaluate.

That being said, this is open source and we are very open to contribution, so feel free to open a PR.

[matanbanin]

How can i implement it on python>=3.5 and that it will still be backward compatible?

[cbefus]

@matanbanin Yes that is my struggle too! If you look at the PR I made above I tried adding them in a way that works for all versions of Python but the hinting doesnt seem 100% correct. Feel free to pull that branch as a initial starting point!

[matanbanin]

I can't create a new branch, so i'll post my code here optional.py

It seems to work on my python, is this code compatible on older versions?

from typing import Any, TypeVar, Generic

from optional.abstract_optional import AbstractOptional
from .nothing import Nothing
from .something import Something

T = TypeVar('T')

class Optional(Generic[T]):
@classmethod
def of(cls, thing: T = None) -> AbstractOptional[T]:
return Nothing(cls) if thing is None else Something(thing, cls)

@classmethod
def empty(cls):
    # type: () -> 'Nothing'
    return Nothing(cls)

int = Optional.of(1)
int.get()

[cbefus]

Unfortunately, what you did above is not completely backwards compatible. Pre 3.5 versions of python only accept the comment style of hints so your line:

def of(cls, thing: T = None) -> AbstractOptional[T]:

would cause problems due to both the : T = None and the -> AbstractOptional[T].

I made a branch called Typing which is close. @dpassen might get a chance to review it this weekend.

[matanbanin]

from typing import Any, TypeVar, Generic

from optional.abstract_optional import AbstractOptional
from .nothing import Nothing
from .something import Something

T = TypeVar('T')

class Optional(Generic[T]):
@classmethod
def of(cls, thing= None):
# type: (T) -> AbstractOptional[T]
return Nothing(cls) if thing is None else Something(thing, cls)

@classmethod
def empty(cls):
    # type: () -> 'Nothing'
    return Nothing(cls)

int = Optional.of(1)
int.get()

And this?

[matanbanin]

?

[cbefus]

@dpassen this is solved by new version right?

[dpassen]

Using pyright language server, this is what I see using the lib:

[cbefus]

lgtm closing