Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit daf4218

Browse files
committedNov 18, 2022
media: atomisp: make hive_int8 explictly signed
The current definition of hive_int8 is a naked char, without any sign specifier. This is incorrect on platforms such as arm, where char is unsigned. Fortunately nothing in the kernel actually uses a hive_int8 type, but in case it gets used later rather than removed, this makes it explicitly signed. Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Sakari Ailus <sakari.ailus@linux.intel.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
1 parent 7392134 commit daf4218

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎drivers/staging/media/atomisp/pci/hive_types.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ typedef unsigned int hive_bool;
4242
#define hive_false 0
4343
#define hive_true 1
4444

45-
typedef char hive_int8;
45+
typedef signed char hive_int8;
4646
typedef short hive_int16;
4747
typedef int hive_int32;
4848
typedef long long hive_int64;

0 commit comments

Comments
 (0)
Failed to load comments.