fix(thiserror): Migrate to v2

This require add `thiserror` as direct dependencies of crate that use.
Our previous way of providing `thiserror` from a utils crate no longer
work CF issue [dtolnay/thiserror#386](dtolnay/thiserror#386).

This could be fixed by
[rust-lang/rust#54363](rust-lang/rust#54363).

To limit further error, `thiserror` is not longer re-exported by
`libparsec_types`.

Author: FirelightFlagboy

Cargo.lock

@@ -40,6 +40,7 @@ libparsec_testbed = { workspace = true, optional = true }
 libparsec_tests_fixtures = { workspace = true, optional = true }
 
 log = { workspace = true }
+thiserror = { workspace = true }
 
 [target.'cfg(not(target_arch = "wasm32"))'.dependencies]
 libparsec_platform_mountpoint = { workspace = true }

libparsec/Cargo.toml

@@ -26,6 +26,7 @@ paste = { workspace = true }
 log = { workspace = true }
 blahaj = { workspace = true }
 smallvec = { workspace = true }
+thiserror = { workspace = true }
 
 [dev-dependencies]
 libparsec_tests_lite = { workspace = true }

libparsec/crates/client/Cargo.toml

@@ -1,6 +1,6 @@
 // Parsec Cloud (https://parsec.cloud) Copyright (c) BUSL-1.1 2016-present Scille SAS
 
-use libparsec_types::{anyhow, thiserror, AvailableDevice};
+use libparsec_types::{anyhow, AvailableDevice};
 
 use crate::ClientConfig;
 

libparsec/crates/client/src/device/mod.rs

@@ -25,6 +25,7 @@ libparsec_types = { workspace = true }
 zeroize = { workspace = true, features = ["alloc"] }
 log = { workspace = true }
 itertools = { workspace = true }
+thiserror = { workspace = true }
 
 [target.'cfg(not(target_arch = "wasm32"))'.dependencies]
 dirs = { workspace = true }

libparsec/crates/platform_device_loader/Cargo.toml

@@ -20,6 +20,7 @@ libparsec_testbed = { workspace = true, optional = true }
 libparsec_platform_async = { workspace = true, optional = true }
 
 log = { workspace = true }
+thiserror = { workspace = true }
 
 [target.'cfg(not(target_arch = "wasm32"))'.dependencies]
 tokio = { workspace = true, features = ["rt"] }

libparsec/crates/platform_ipc/Cargo.toml

@@ -15,6 +15,8 @@ workspace = true
 libparsec_types = { workspace = true }
 libparsec_platform_async = { workspace = true }
 
+thiserror = { workspace = true }
+
 [target.'cfg(not(target_arch = "wasm32"))'.dependencies]
 tokio = { workspace = true, features = ["fs", "sync"] }
 # We add this dependency to have sqlite3 bundled into our code.

libparsec/crates/platform_realm_export/Cargo.toml

@@ -24,6 +24,7 @@ libparsec_testbed = { workspace = true, optional = true }
 log = { workspace = true }
 paste = { workspace = true }
 lazy_static = { workspace = true, optional = true }
+thiserror = { workspace = true }
 
 [target.'cfg(not(target_arch = "wasm32"))'.dependencies]
 tokio = { workspace = true, features = ["fs", "sync"] }

libparsec/crates/platform_storage/Cargo.toml

@@ -2,8 +2,6 @@
 
 use thiserror::Error;
 
-use libparsec_types::prelude::*;
-
 // TODO: remove me: seems only used in the python bindings
 #[derive(Error, Debug, Clone, PartialEq, Eq)]
 pub enum ProtocolError {

libparsec/crates/protocol/src/error.rs

@@ -42,7 +42,7 @@ regex-syntax = { workspace = true, features = ["unicode-perl"] }
 unicode-normalization = { workspace = true, features = ["std"] }
 paste = { workspace = true }
 rand = { workspace = true, features = ["std", "std_rng"] }
-thiserror = { workspace = true }
+thiserror = { workspace = true, features = ["std"] }
 email-address-parser = { workspace = true }
 anyhow = { workspace = true, features = ["std", "backtrace"] }
 flate2 = { workspace = true }

libparsec/crates/types/Cargo.toml

@@ -42,7 +42,7 @@ pub enum DataError {
     #[error("Invalid user ID: expected `{expected}`, got `{got}`")]
     UnexpectedUserID { expected: UserID, got: UserID },
 
-    // `HumanHandle` is 72bytes long, so boxing is needed to limit presure on the stack
+    // `HumanHandle` is 72bytes long, so boxing is needed to limit pressure on the stack
     #[error("Invalid HumanHandle, expected `{expected}`, got `{got}`")]
     UnexpectedHumanHandle {
         expected: Box<HumanHandle>,

libparsec/crates/types/src/error.rs

@@ -26,7 +26,6 @@ extern crate lazy_static;
 pub use anyhow;
 pub use bytes;
 pub use bytes::Bytes;
-pub use thiserror;
 pub use uuid;
 
 // Re-expose crypto so that `use libparsec_types::prelude::*` is the single-no-brainer-one-liner™