Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[amp story shopping] Build shopping CTA #36697

Closed
processprocess opened this issue Nov 1, 2021 · 0 comments · Fixed by #36721
Closed

[amp story shopping] Build shopping CTA #36697

processprocess opened this issue Nov 1, 2021 · 0 comments · Fixed by #36721

Comments

@processprocess
Copy link
Contributor

processprocess commented Nov 1, 2021

Description

  1. Render a CTA on pages with the amp-story-shopping-attachment. This could happen here and here

It is okay for it to display the default "Swipe up" text. A follow up PR #36698 will set the text.
Screen Shot 2021-11-02 at 10 34 40 AM

  1. Ensure setting a theme attribute works on the CTA.
  2. Add a visual diff test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants