🐛 Added back JS for vh #36719
Merged
🐛 Added back JS for vh #36719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gmajoulet, @newmuis! These files were changed: |
gmajoulet
approved these changes
Nov 2, 2021
kristoferbaxter
approved these changes
Nov 2, 2021
|
Given how this behavior relies on certain browsers' |
ampprojectbot
pushed a commit
that referenced
this pull request
Nov 2, 2021
(cherry picked from commit 4b43359)
ampprojectbot
pushed a commit
that referenced
this pull request
Nov 2, 2021
(cherry picked from commit 4b43359)
jridgewell
reviewed
Nov 2, 2021
| this.cssVariablesStyleEl_.setAttribute('type', 'text/css'); | ||
| doc.head.appendChild(this.cssVariablesStyleEl_); | ||
| } | ||
| this.cssVariablesStyleEl_.textContent = `:root {--story-page-vh: ${px( |
There was a problem hiding this comment.
Nit: Why isn't this just an inline style on the <html> element?
There was a problem hiding this comment.
Specifically for this PR it's because it used to be like that, so I reverted that back.
In general, I think inlining the style would have made more sense (+ you don't have to keep track of this extra element).
ampprojectbot
pushed a commit
that referenced
this pull request
Nov 2, 2021
(cherry picked from commit 4b43359)
rileyajones
pushed a commit
to rileyajones/amphtml
that referenced
this pull request
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36711
Reverts removing the JS units calculation from #36033
Before / After (URLs match the original story and the demo story with change)
Also tested, and the styles for the desktop one-panel are not affected by the bug, and are also not affected by this fix (those styles are overriden). Also, the desktop one-panel is not shown on mobile UIs.