This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(checkbox): update CSS to match spec #8713
Closed
+119
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Part of #8209 |
clshortfuse
force-pushed
the
specFix-checkbox
branch
2 times, most recently
from
1decfdd to
69169d6
Compare
clshortfuse
force-pushed
the
specFix-checkbox
branch
6 times, most recently
from
a820435 to
3610828
Compare
clshortfuse
force-pushed
the
specFix-checkbox
branch
5 times, most recently
from
8aeb8e8 to
6d3c4f1
Compare
clshortfuse
added
Blocked
clshortfuse
force-pushed
the
specFix-checkbox
branch
from
6d3c4f1 to
e240126
Compare
clshortfuse
changed the title
clshortfuse
added
needs: review
clshortfuse
force-pushed
the
specFix-checkbox
branch
2 times, most recently
from
1153247 to
2ab3aee
Compare
clshortfuse
removed
the
g3: pr
Splaktar
changed the title
Splaktar
approved these changes
Jan 2, 2018
Splaktar
added
pr: merge ready
|
My guess is that the Google presubmit tests will break due to finicky screenshot tests. But let's give it a shot as see how it goes. |
|
I really like the changes here, but unfortunately this failed the presubmit process due to the following “won’t be able to be merged since it breaks a lot of screendiffs (lots of changes in padding)“. So this is currently on hold until we can determine if it is possible to move forward without requiring all of the screenshot tests within Google to pass. |
|
Updating: this causes around 80 different test failures for Google apps; it's unlikely we can merge it |
Splaktar
added
pr: lgtm
Splaktar
added
P2: required
Splaktar
added
needs: rebase
Splaktar
pushed a commit
that referenced
this pull request
Jun 19, 2020
Checkbox did not support a11y minimum touch target and the box was larger than spec - Change checkbox size from 20px to 18px - Keep horizontal size flush when text is blank - Add md-dense support for checkbox - Add inline alignment math to SCSS - Increase size of md-checkbox to properly support touch - Add demo for md-dense support Fixes #9351. Fixes #9927. Closes #8713.
3 tasks
Splaktar
pushed a commit
that referenced
this pull request
Jun 29, 2020
Checkbox did not support a11y minimum touch target and the box was larger than spec. - Change checkbox size from 20px to 18px - Keep horizontal size flush when text is blank - Add md-dense support for checkbox - Add inline alignment math to SCSS - Increase size of md-checkbox to properly support touch - Add demo for md-dense support Fixes #9351. Fixes #9927. Closes #8713. BREAKING CHANGE: The default size and spacing for `md-checkbox` has been updated to align with the Material Design specification. Additionally, many new Sass variables have been added for customizing the size and spacing of `md-checkbox`. The `md-dense` class is now supported. After updating to this version, you may need to adjust the layout of your app due to the larger touch-friendly size of checkbox. You may also want to make use of `md-dense` in cases where space is limited.
Splaktar
pushed a commit
that referenced
this pull request
Jun 29, 2020
Checkbox did not support a11y minimum touch target and the box was larger than spec. - Change checkbox size from 20px to 18px - Keep horizontal size flush when text is blank - Add md-dense support for checkbox - Add inline alignment math to SCSS - Increase size of md-checkbox to properly support touch - Add demo for md-dense support Fixes #9351. Fixes #9927. Closes #8713. BREAKING CHANGE: The default size and spacing for `md-checkbox` has been updated to align with the Material Design specification. Additionally, many new Sass variables have been added for customizing the size and spacing of `md-checkbox`. The `md-dense` class is now supported. After updating to this version, you may need to adjust the layout of your app due to the larger touch-friendly size of checkbox. You may also want to make use of `md-dense` in cases where space is limited.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkbox did not support a11y minimum touch target and the box was
larger than spec
Fixes #9351, #9927