Avoid dynamically typed .from methods (#8147)

Author: parlough

app/lib/admin/tools/delete_all_staging.dart

@@ -87,7 +87,7 @@ Future<void> _batchedQuery<T extends Model>(
 
   void flush() {
     if (keys.isEmpty) return;
-    fn(List.from(keys));
+    fn(List.of(keys));
     keys.clear();
     budget = _defaultBudget;
   }

app/lib/frontend/handlers/account.dart

@@ -203,9 +203,10 @@ Future<LikedPackagesResponse> listPackageLikesHandler(
   final authenticatedUser = await requireAuthenticatedWebUser();
   final user = authenticatedUser.user;
   final packages = await likeBackend.listPackageLikes(user);
-  final List<PackageLikeResponse> packageLikes = List.from(packages.map(
-      (like) => PackageLikeResponse(
-          liked: true, package: like.package, created: like.created)));
+  final List<PackageLikeResponse> packageLikes = packages
+      .map((like) => PackageLikeResponse(
+          liked: true, package: like.package, created: like.created))
+      .toList();
   return LikedPackagesResponse(likedPackages: packageLikes);
 }
 

app/lib/frontend/handlers/custom_api.dart

@@ -461,8 +461,7 @@ Future<shelf.Response> apiSearchHandler(shelf.Request request) async {
     if (sr.errorMessage != null) 'message': sr.errorMessage,
   };
   if (hasNextPage) {
-    final newParams =
-        Map<String, dynamic>.from(request.requestedUri.queryParameters);
+    final newParams = {...request.requestedUri.queryParameters};
     newParams['page'] = (searchForm.currentPage! + 1).toString();
     final nextPageUrl =
         request.requestedUri.replace(queryParameters: newParams).toString();

app/lib/frontend/static_files.dart

@@ -200,7 +200,7 @@ class StaticFileCache {
   String get etag => _etag ??= _calculateEtagOfEtags().substring(0, 8);
 
   String _calculateEtagOfEtags() {
-    final files = List<StaticFile>.from(_files.values);
+    final files = _files.values.toList();
     files.sort((a, b) => a.requestPath.compareTo(b.requestPath));
     final concatenatedEtags = files.map((f) => f.etag).join(' ');
     final digest = crypto.sha256.convert(utf8.encode(concatenatedEtags));
@@ -402,8 +402,7 @@ class ParsedStaticUrl {
 
   factory ParsedStaticUrl.parse(Uri requestedUri) {
     final normalizedRequestPath = path.normalize(requestedUri.path);
-    final pathSegments =
-        List<String>.from(Uri(path: normalizedRequestPath).pathSegments);
+    final pathSegments = List.of(Uri(path: normalizedRequestPath).pathSegments);
     String? pathHash;
     var filePath = normalizedRequestPath;
     if (pathSegments.length > 2 && pathSegments[1].startsWith('hash-')) {

app/lib/search/models.dart

@@ -3,6 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:clock/clock.dart';
+import 'package:collection/collection.dart';
 import 'package:json_annotation/json_annotation.dart';
 import 'package:pub_dev/shared/popularity_storage.dart';
 
@@ -59,8 +60,7 @@ extension UpdateLikesExt on Iterable<PackageDocument> {
   /// The score is normalized into the range of [0.0 - 1.0] using the
   /// ordered list of packages by like counts (same like count gets the same score).
   void updateLikeScores() {
-    final sortedByLikes = List<PackageDocument>.from(this)
-      ..sort((a, b) => a.likeCount.compareTo(b.likeCount));
+    final sortedByLikes = sorted((a, b) => a.likeCount.compareTo(b.likeCount));
     for (var i = 0; i < sortedByLikes.length; i++) {
       if (i > 0 &&
           sortedByLikes[i - 1].likeCount == sortedByLikes[i].likeCount) {

app/lib/search/search_service.dart

@@ -128,7 +128,7 @@ class PackageDocument {
   Map<String, dynamic> toJson() => _$PackageDocumentToJson(this);
 
   @JsonKey(includeFromJson: false, includeToJson: false)
-  late final tagsForLookup = Set<String>.from(tags);
+  late final Set<String> tagsForLookup = Set.of(tags);
 }
 
 /// A reference to an API doc page

app/lib/service/youtube/backend.dart

@@ -82,7 +82,7 @@ class YoutubeBackend {
 /// Algorithm description at [YoutubeBackend.getTopPackageOfWeekVideos].
 @visibleForTesting
 List<T> selectRandomVideos<T>(math.Random random, List<T> source, int count) {
-  final selectable = List<T>.from(source);
+  final selectable = List.of(source);
   final selected = <T>[];
   while (selected.length < count && selectable.isNotEmpty) {
     if (selected.isEmpty) {

app/lib/shared/configuration.dart

@@ -5,7 +5,6 @@
 import 'dart:convert' show json;
 import 'dart:io';
 
-import 'package:collection/collection.dart' show UnmodifiableSetView;
 import 'package:gcloud/service_scope.dart' as ss;
 import 'package:json_annotation/json_annotation.dart';
 import 'package:meta/meta.dart';
@@ -454,7 +453,7 @@ class AdminId {
     required this.oauthUserId,
     required this.email,
     required Iterable<AdminPermission?> permissions,
-  }) : permissions = UnmodifiableSetView(Set.from(permissions));
+  }) : permissions = Set.unmodifiable(permissions.nonNulls);
 
   factory AdminId.fromJson(Map<String, dynamic> json) =>
       _$AdminIdFromJson(json);

app/lib/shared/markdown.dart

@@ -318,7 +318,7 @@ String _rewriteAbsoluteUrl(String url) {
   if (uri.host == 'github.com') {
     final segments = uri.pathSegments;
     if (segments.length > 3 && segments[2] == 'blob') {
-      final newSegments = List<String>.from(segments);
+      final newSegments = List.of(segments);
       newSegments[2] = 'raw';
       return uri.replace(pathSegments: newSegments).toString();
     }

app/lib/shared/urls.dart

@@ -398,7 +398,7 @@ String? getRepositoryUrl(
   }
   try {
     final uri = Uri.parse(repository!);
-    final segments = List<String>.from(uri.pathSegments);
+    final segments = List.of(uri.pathSegments);
     while (segments.isNotEmpty && segments.last.isEmpty) {
       segments.removeLast();
     }

app/lib/shared/utils.dart

@@ -135,7 +135,7 @@ class LastNTracker<T extends Comparable<T>> {
 
   T? _getP(double p) {
     if (_lastItems.isEmpty) return null;
-    final List<T> list = List.from(_lastItems);
+    final List<T> list = _lastItems.toList();
     list.sort();
     return list[(list.length * p).floor()];
   }

app/lib/task/cloudcompute/googlecloudcompute.dart

@@ -356,7 +356,7 @@ final class _GoogleCloudCompute extends CloudCompute {
   );
 
   @override
-  List<String> get zones => List.from(_zones);
+  List<String> get zones => List.of(_zones);
 
   @override
   String generateInstanceName() => 'worker-${Ulid()}';

pkg/fake_gcloud/lib/mem_datastore.dart

@@ -21,7 +21,7 @@ class MemDatastore implements Datastore {
   Future<List<Key>> allocateIds(List<Key> keys) async {
     return keys.map((k) {
       if (k.elements.last.id == null) {
-        final elements = List<KeyElement>.from(k.elements);
+        final elements = List.of(k.elements);
         final last = elements.removeLast();
         elements.add(KeyElement(last.kind, _unusedId++));
         return Key(elements, partition: k.partition);