A3-1-5: Remove extraneous cases and handle template instantiations #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knewbury01
requested changes
Jun 18, 2024
knewbury01
requested changes
Jun 18, 2024
There was a problem hiding this comment.
also, one more oddity, not sure how this file name was passing our length check before (ie it wasnt but also wasnt getting checked?)
not sure what to do about that part, either rename, or figure out while older query names are not/if they should be made to also comply with that
| @@ -23,7 +23,7 @@ class A { | |||
|
|
|||
| int complexCalculation(); | |||
|
|
|||
There was a problem hiding this comment.
oh, also needs a test format
knewbury01
reviewed
Jun 19, 2024
There was a problem hiding this comment.
oh, @lcartey , one other thing. nevermind! addressed this in this PR instead
perhaps consider fixing #611 at the same time? it is also for this query
possibly something like this? here:
predicate hasTrivialLength() {
this.getBlock().getLastStmt().getLocation().getStartLine() - this.getBlock().getStmt(0).getLocation().getStartLine() <= 10 and
not exists(this.getBlock().getStmt(_).getChildStmt())
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #382 and #481.
Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
A3-1-5Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.