Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M0-1-9: False-positive for all static_assert declarations #9

Closed
nicolaswill opened this issue Jul 15, 2022 · 0 comments · Fixed by #63
Closed

M0-1-9: False-positive for all static_assert declarations #9

nicolaswill opened this issue Jul 15, 2022 · 0 comments · Fixed by #63
Assignees
@lcartey
Labels
Difficulty-Low A false positive or false negative report which is expected to take <1 day effort to address false positive/false negative An issue related to observed false positives or false negatives. Impact-High top-25-fps user-report Issue reported by an end user of CodeQL Coding Standards

Comments

@nicolaswill
Copy link
Contributor

Affected rules

  • M0-1-9

Description

This rule produces false-positives for the bool-constexpr of every declaration of static_assert. We can probably resolve this case by excluding all Expr that are within StaticAssert::getCondition().
@nicolaswill nicolaswill added Difficulty-Low A false positive or false negative report which is expected to take <1 day effort to address Impact-Medium user-report Issue reported by an end user of CodeQL Coding Standards false positive/false negative An issue related to observed false positives or false negatives. labels Jul 15, 2022
@lcartey lcartey self-assigned this Aug 12, 2022
@lcartey lcartey mentioned this issue Aug 18, 2022
Merged
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lcartey lcartey

Labels
Difficulty-Low A false positive or false negative report which is expected to take <1 day effort to address false positive/false negative An issue related to observed false positives or false negatives. Impact-High top-25-fps user-report Issue reported by an end user of CodeQL Coding Standards
Projects
Coding Standards Public Development Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

M0-1-9: Exclude more compiler generated statements lcartey/codeql-coding-standards
2 participants
@lcartey @nicolaswill