Skip to content

Archive call has the wrong ostream types #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rakishii13 opened this issue May 11, 2022 · 1 comment
Open

Archive call has the wrong ostream types #1439

rakishii13 opened this issue May 11, 2022 · 1 comment
Labels
waiting for feedback

Comments

@rakishii13
Copy link

Hi, over here, https://github.com/gitpython-developers/GitPython/blob/main/git/repo/base.py#L1151 why is this Union[TextIO, BinaryIO] instead of IO[bytes]? As sending a temporaryfile or any file, is not in Union[TextIO, BinaryIO] and it is in IO[bytes]
@Byron
Copy link
Member

Byron commented May 11, 2022

It would help to post the underlying problem as well. Is type checking failing where it shouldn't?
The runtime shouldn't be affected by the typing at all.

That said, if the typing gets better if the type is changed to something else, a PR is certainly welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
waiting for feedback
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Byron @rakishii13