Skip to content

GitConfigParser doesn't ignore comments at the end of the line #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jesustorresdev opened this issue Jan 31, 2018 · 0 comments
Open

Comments

@jesustorresdev
Copy link

GitConfigParser doesn't ignore comments at the end of the line. So, with a configuration file with the next content:

[alias]
  a = add    # add

'add # add' is saved as the value of a.
That isn't a big problem. But if the configuration file contains something like this:

[mergetool "mvimdiff"]
  cmd="mvim -c 'Gdiff' $MERGED"     # use fugitive.vim for 3-way merge
  keepbackup=false

The multi line mode is enabled at config.py#L347 (is_multi_line) and the rest of options are ignored because every line is added as the value of cmd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants