Skip to content

Pull raises GitCommandError with no error message #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Carbenium opened this issue Mar 18, 2019 · 3 comments
Open

Pull raises GitCommandError with no error message #856

Carbenium opened this issue Mar 18, 2019 · 3 comments

Comments

@Carbenium
Copy link

GitPython: 2.1.11
Python: 3.5
Git: 2.20.1

repo.remotes.orgin.pull() can lead to GitCommandError with no error message.

Running git pull in the terminal leads to exit code 1 and following error message :

Your configuration specifies to merge with the ref 'refs/heads/patch1'
from the remote, but no such ref was fetched.

The GitCommandError should contain the message as well.

@Byron
Copy link
Member

Byron commented Jul 20, 2019

Thanks a lot for letting me know!

The remote message parsing unfortunately is inherently flaky and probably incorrect in many places, which is why I think it's OK to acknowledge this one even without having tried to reproduce it.

@farhaanbukhsh
Copy link

hey @Byron I would like to work on this, can you tell me how to go forward with it?

@Byron
Copy link
Member

Byron commented Oct 15, 2019

@farhaanbukhsh Thanks for offering your help! You could start to have a look at the contribution guidelines, followed by an explanation on how to run tests.

The test-suite is quite high-level, preferring to operate on integration level (i.e. actually doing things) rather than on unit level (i.e. where the test is fully isolated and tests only a small portion of the code). This doesn't make it easy to write test for remote pulls/fetches, unfortunately. Maybe you can have a look at the existing tests for remotes to see if you could manufacture something that reproduces the issue described here.

Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants