- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 934
Git windows 2.22.0 breaks with submodule add #885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Same on linux:
Note the first invocation is a usage error (showing the original issue reported for Windows is present on Linux); the second one got past that and errored out for a different (and expected) reason. |
@georgealverson could you post the complete stack trace so we can see where it originates from? |
Hi, The pertinent section is marked below with '>>>'. I haven't checked under Linux, but I believe your example should not work unless you have an available repo under ../../utils. That's what the error message seems to indicate. Best, Traceback (most recent call last):
File "C:\Users\galve\AppData\Local\Programs\Python\Python36\lib\site-packages\git\cmd.py", line 548, in |
Actually, what I posted clearly shows one way is a usage error and the other way is as you said, but it proves the change to a more strict command line processing in git. |
Yes, of course. Always read to the end of the message! |
The traceback below shows that git for windows has become pickier
in the latest release (2.22.0). It appears it will no longer accept git
submodule -b add .
This works fine in 'git version 2.21.0.windows.1'.
========================================
gt.submodule('add','../../utils',b='master')
\Python36\lib\site-packages\git\cmd.py", line 548, in
return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
\Python36\lib\site-packages\git\cmd.py", line 1014, in _call_process
return self.execute(call, **exec_kwargs)
\Python36\lib\site-packages\git\cmd.py", line 825, in execute
raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(1)
cmdline: git submodule -b master add ../../utils
stderr: 'usage: git submodule [--quiet] [--cached]
or: git submodule [--quiet] add [-b ] [-f|--force] [--name ] [--reference ] [--]
The text was updated successfully, but these errors were encountered: