Skip to content

Add support for --progress when updating submodules #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
therocode opened this issue Jun 30, 2019 · 1 comment
Open

Add support for --progress when updating submodules #887

therocode opened this issue Jun 30, 2019 · 1 comment

Comments

@therocode
Copy link

When using the class UpdateProgress to monitor the progress of submodules updating, you don't get a lot of progress from the CLONE step (it only has a max_count of 1) and for some submodules this takes a really long time, meaning it is hard to make a good UX for this case.

I assume the progress is not reported in more detail due to how the progress is not shown when using git itself on the commandline. However, there is now a flag for this in git -> https://stackoverflow.com/a/48283379/2164642

This sounds to me like it would be possible to improve the progress reporting of submodules to be a lot more informative similar to the normal top-level cloning.

@Byron
Copy link
Member

Byron commented Jul 20, 2019

Thanks for the description! It should be relatively straightforward to pass flags down to git-clone from the submodule implementation. Maybe it's already possible, most methods support **kwargs for that purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants