Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExecutionType and ArtifactType themselves need properties and metadata #30

Open
Ark-kun opened this issue Jan 30, 2020 · 3 comments
Open

Comments

@Ark-kun
Copy link

Ark-kun commented Jan 30, 2020

For ExecutionType, we want to store the ComponentSpec that is used to spawn the Executions.
For ArtifactType we want to store some information like deep JSON schema, visualization parameters serializers etc.

@hughmiao
Copy link
Contributor

hughmiao commented Feb 1, 2020

We discussed this before as static properties of the Artifact/ExecutionType. latter some of these problem can be resolved by putting it to some PipelineContext, as per pipeline or per run properties. Will this approach work for you?

@Ark-kun
Copy link
Author

Ark-kun commented Feb 11, 2020

We discussed this before as static properties of the Artifact/ExecutionType. latter some of these problem can be resolved by putting it to some PipelineContext, as per pipeline or per run properties. Will this approach work for you?

Context is a different entity. ArtifactTypes and ExecutionTypes are not limited to a single Context or ContextType.

Can the MLMD team just add custom_properties to ArtifactTypes and ExecutionTypes? I think it should be doable.

@Ark-kun
Copy link
Author

Ark-kun commented Feb 28, 2020

Are there any objections to adding custom_properties to ArtifactType and ExecutionType?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants