-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(logging): Use instance/attributes/cluster-location for location on GKE #9094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
Pull request size is small.
api: logging
Issues related to the Cloud Logging API.
labels
Dec 7, 2023
Thanks. Once this is merged, I imagine it will be mentioned in the next release change log. For users writing |
cindy-peng
approved these changes
Dec 11, 2023
product-auto-label
bot
added
size: m
Pull request size is medium.
and removed
size: s
Pull request size is small.
labels
Dec 11, 2023
gkevinzheng
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
and removed
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
labels
Dec 11, 2023
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Dec 11, 2023
bhshkh
approved these changes
Dec 11, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
instance/attributes/cluster-location
for location on GKE to set the value of location to the cluster location as opposed to just the zone, to bring it in line with what other logging libraries do: see https://github.com/googleapis/google-cloud-cpp/blob/4ba2cc4d1d0cfdd70dec6d1affb26423d0e9dac1/google/cloud/opentelemetry/internal/resource_detector_impl.cc#L103C51-L103C67 and https://github.com/googleapis/google-cloud-cpp/blob/850564f330ac6e918d6d40ac1ab17a200282a196/google/cloud/opentelemetry/internal/monitored_resource.cc#L88 for C++, and for what is tagged under location in other GKE logging statements.See also https://cloud.google.com/kubernetes-engine/docs/concepts/workload-identity#instance_metadata
Fixes #9083 #9070