Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add simple query connection read api sample #3394

Merged
merged 7 commits into from
Jul 26, 2024
Merged

Conversation

PhongChuong
Copy link
Contributor

@PhongChuong PhongChuong commented Jul 17, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #3404 ☕️

Copy link

conventional-commit-lint-gcf bot commented Jul 17, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/java-bigquery API. samples Issues that are directly related to samples. labels Jul 17, 2024
@PhongChuong PhongChuong marked this pull request as ready for review July 25, 2024 22:39
Copy link

snippet-bot bot commented Jul 25, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@PhongChuong PhongChuong assigned shollyman and unassigned bourgeoisor Jul 25, 2024
@PhongChuong PhongChuong changed the title chore: add simple query connection read api sample docs: add simple query connection read api sample Jul 25, 2024
@PhongChuong
Copy link
Contributor Author

Thanks for the review.

@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners July 25, 2024 23:18
@gcf-owl-bot gcf-owl-bot bot requested a review from Neenu1995 July 25, 2024 23:18
@PhongChuong PhongChuong merged commit d407baa into main Jul 26, 2024
20 checks passed
@PhongChuong PhongChuong deleted the b349465856 branch July 26, 2024 13:16
lqiu96 pushed a commit that referenced this pull request Aug 28, 2024
* Basic setup for connection api sample using simple query

* Update sample to use Connection

* Fix import/lint

* Fix import order

* Remove closing result set as it is not implemented

* Remove necessary TODO comment

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add code snippet for using Connection
3 participants