Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Apply fixes from Google error-prone #1010

Merged
merged 2 commits into from
Aug 18, 2022
Merged

fix: Apply fixes from Google error-prone #1010

merged 2 commits into from
Aug 18, 2022

Conversation

bpcreech
Copy link
Contributor

Fixes #1009

@bpcreech bpcreech requested review from a team as code owners July 23, 2022 20:26
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: logging Issues related to the googleapis/java-logging API. size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jul 23, 2022
@losalex losalex self-assigned this Jul 31, 2022
losalex
losalex approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@losalex losalex changed the title Apply fixes from Google error-prone fix: Apply fixes from Google error-prone Aug 10, 2022
losalex
losalex reviewed Aug 18, 2022
View reviewed changes
Copy link
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the cli check fails with following error:

Warning: Used undeclared dependencies found:
Warning: com.google.errorprone:error_prone_annotations:jar:2.14.0:compile

Perhaps you can take a look?

@bpcreech
Copy link
Contributor Author

Argh, my bad, I didn't run the dependencies check on this and thus didn't add the error-prone annotations to pom.xml, and the test failed. Fixed!

@losalex losalex added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 18, 2022
@losalex losalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2022
@losalex losalex merged commit 2d57d78 into googleapis:main Aug 18, 2022
@release-please release-please bot mentioned this pull request Aug 18, 2022
Merged
@bpcreech bpcreech mentioned this pull request Aug 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losalex losalex losalex approved these changes

Assignees

@losalex losalex

Labels
api: logging Issues related to the googleapis/java-logging API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Various Google error-prone findings
3 participants
@bpcreech @losalex @yoshi-kokoro