-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: regenerating with new Protobuf (3.7.x) #1130
Conversation
Warning: This pull request is touching the following templated files:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems build is failed...
@losalex thanks for looking! It looks like some of the jobs are failing with:
|
Hm adding |
@@ -27,6 +27,7 @@ fi | |||
# make sure submodule is up to date | |||
cd "$PROJECT_ROOT" | |||
git submodule update --init --recursive | |||
git config --global --add safe.directory '*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this should be moved up a line. It needs to run before git submodule update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh! good catch. I'll modify this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the failing GraalVM
tests though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @daniel-sanche for comment - indeed, this seems as an issue!
As for GraalVM
, I am not sure - I need to look into those
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applying this change seemed to have worked!
Thank you both so much for troubleshooting this! Merging this PR now. |
To merge into 3.7.x branch. This PR was generated using Protobuf 3.19.6. Source-Link: googleapis/googleapis@c7ca416