Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include x-goog-user-project on resumable upload puts for grpc transport #2586

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

BenWhitehead
Copy link
Collaborator

No description provided.

…ansport

In HTTP transport, gcs includes the userProject in the returned location. However, in grpc the upload is opaque and does not necessarily include the userProject in a client visible way. For completeness’s sake, include x-goog-user-project in resumable upload puts.
@BenWhitehead BenWhitehead added the owlbot:ignore instruct owl-bot to ignore a PR label Jun 13, 2024
@BenWhitehead BenWhitehead requested a review from a team as a code owner June 13, 2024 15:22
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/java-storage API. labels Jun 13, 2024
@BenWhitehead BenWhitehead merged commit 6f2f504 into main Jun 13, 2024
20 of 21 checks passed
@BenWhitehead BenWhitehead deleted the fix/grpc/requester-pays-resumable-puts branch June 13, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants