fix: Correction for timestamp and instrumentation record severity fields format #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
daniel-sanche
approved these changes
Sep 3, 2022
There was a problem hiding this comment.
I'd suggest considering using RFC3339 instead of this format, and possibly expanding the tests, but overall LGTM as is
Opened 1329 for this suggestion. I believe the only benefit of this is readability for raw JSON payload printed to stdout and/or HTTP/S, hence making this P3.
losalex
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that
timestampformat for log records printed to stdout are in wrong format - the right format is defined here: timestamp-processing. Worth mentioning that changing this format should be safe despite a fact thatStructuredJsondefined as external - it is used internally and I believe it is safe to change format oftimestamp.Also instrumentation record was setting
severityas number and since it should be withDEFAULTseverity, removing it from instrumentation record.Related to # 1266 🦕