fix: Ensure no double execution for to_pandas #1032
Merged
+18
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
sycai
approved these changes
Oct 1, 2024
| pd.testing.assert_frame_equal( | ||
| df.explode(col_names, ignore_index=ignore_index).to_pandas(), | ||
| pd_df.explode(col_names, ignore_index=ignore_index), | ||
| check_index_type=False, | ||
| check_dtype=False, | ||
| ) | ||
| execs_post = metrics.execution_count | ||
| # we test this property on this method in particular as compilation | ||
| # is non-deterministic and won't use the query cache as implemented |
There was a problem hiding this comment.
nit: I would also document that this is to check that the execution was performed only once
There was a problem hiding this comment.
reorganized a bit to make clear that only care about executions from the to_pandas() invocation.
| pd_df = df.to_pandas() | ||
| execs_pre = metrics.execution_count |
There was a problem hiding this comment.
nit: put this line right below line 4831 or move line 4831 above this line, just to keep together statements that are related
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕