Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the ground_with_google_search option for GeminiTextGenerator predict #1119

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

chelsea-lin
Copy link
Contributor

This change introduces a new option, ground_with_google_search, for the predict method in the GeminiTextGenerator. This option also is extended to all semantic operations processed by the GeminiTextGenerator model.

@chelsea-lin chelsea-lin requested a review from jiaxunwu October 29, 2024 18:09
@chelsea-lin chelsea-lin requested review from a team as code owners October 29, 2024 18:09
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Oct 29, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Oct 29, 2024
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_semops branch from 5a55d69 to 76d6cce Compare October 29, 2024 18:09
@@ -119,6 +129,9 @@ def agg(
)
column = columns[0]

if ground_with_google_search:
warnings.warn("Enables Grounding with Google Search may impact billing.")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add the pricing page link here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks!

@chelsea-lin chelsea-lin requested a review from jiaxunwu October 29, 2024 19:10
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_semops branch from 6f62585 to 17b02dd Compare October 29, 2024 19:11
@chelsea-lin chelsea-lin merged commit ca02cd4 into main Oct 29, 2024
21 of 23 checks passed
@chelsea-lin chelsea-lin deleted the main_chelsealin_semops branch October 29, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants