-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update llm.TextEmbeddingGenerator to 005 #1186
Conversation
merge to main branch to avoid conflict
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@@ -647,7 +647,7 @@ def search( | |||
>>> bigframes.options.experiments.semantic_operators = True | |||
|
|||
>>> import bigframes.ml.llm as llm | |||
>>> model = llm.TextEmbeddingGenerator(model_name="text-embedding-004") | |||
>>> model = llm.TextEmbeddingGenerator(model_name="text-embedding-005") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs tests fail on semantic. These changes are unnecessary. Maybe just revert it.
Update llm.TextEmbeddingGenerator to 005, update feature, docs, and tests. The default value is reamined as text-embedding-004 for better customer experience.
Bug: 381935784