Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update llm.TextEmbeddingGenerator to 005 #1186

Merged
merged 7 commits into from
Dec 6, 2024

Conversation

shuoweil
Copy link
Contributor

@shuoweil shuoweil commented Dec 3, 2024

Update llm.TextEmbeddingGenerator to 005, update feature, docs, and tests. The default value is reamined as text-embedding-004 for better customer experience.

Bug: 381935784

@shuoweil shuoweil requested a review from GarrettWu December 3, 2024 21:32
@shuoweil shuoweil self-assigned this Dec 3, 2024
@shuoweil shuoweil requested review from a team as code owners December 3, 2024 21:32
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Dec 3, 2024
@shuoweil shuoweil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2024
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2024
@shuoweil shuoweil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2024
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2024
@shuoweil shuoweil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2024
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2024
Copy link
Contributor

@GarrettWu GarrettWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -647,7 +647,7 @@ def search(
>>> bigframes.options.experiments.semantic_operators = True

>>> import bigframes.ml.llm as llm
>>> model = llm.TextEmbeddingGenerator(model_name="text-embedding-004")
>>> model = llm.TextEmbeddingGenerator(model_name="text-embedding-005")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs tests fail on semantic. These changes are unnecessary. Maybe just revert it.

@shuoweil shuoweil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2024
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2024
@shuoweil shuoweil merged commit 3072d38 into main Dec 6, 2024
23 checks passed
@shuoweil shuoweil deleted the shuowei-update-textembedding005 branch December 6, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants