feat: Support DF.__array__(copy=True) #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
jialuoo
reviewed
Feb 19, 2025
| @@ -7179,7 +7179,7 @@ def __len__(self): | |||
| """ | |||
| raise NotImplementedError(constants.ABSTRACT_METHOD_ERROR_MESSAGE) | |||
|
|
|||
| def __array__(self): | |||
| def __array__(self, dtype=None, copy=None): | |||
There was a problem hiding this comment.
If copy can be (bool or None, optional), better to use 'copy: Optional[bool] = None' too.
Same for series.
There was a problem hiding this comment.
added annotation
jialuoo
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕