Skip to content
/ python-bigquery-dataframes Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add an example notebook about line graphs #197

Merged
merged 10 commits into from
Nov 15, 2023
Merged

docs: add an example notebook about line graphs #197

merged 10 commits into from
Nov 15, 2023

Conversation

milkshakeiii
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
Page not found · GitHub · GitHub
Skip to content
404 “This is not the web page you are looking for”
Contact Support — GitHub Status — @githubstatus
@milkshakeiii milkshakeiii requested review from a team as code owners November 11, 2023 22:22
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 11, 2023
ashleyxuu
ashleyxuu reviewed Nov 13, 2023
View reviewed changes
Copy link
Contributor

@ashleyxuu ashleyxuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GarrettWu Since @milkshakeiii is on leave now, how about we check in the notebook, and edit it afterwards?

@milkshakeiii
Copy link
Contributor Author

@GarrettWu Since @milkshakeiii is on leave now, how about we check in the notebook, and edit it afterwards?

It's okay, this is my last PR, I can respond to a few comments ! Thanks!

@milkshakeiii milkshakeiii reopened this Nov 14, 2023
@milkshakeiii milkshakeiii added the automerge Merge the pull request once unit tests and other checks pass. label Nov 15, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit f957b27 into main Nov 15, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the b299356569-covid-notebook branch November 15, 2023 02:52
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 15, 2023
@release-please release-please bot mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarrettWu GarrettWu

@ashleyxuu ashleyxuu

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@milkshakeiii @GarrettWu @ashleyxuu