feat: add replace method to DataFrame #261
Conversation
product-auto-label
bot
added
size: m
TrevorBergeron
force-pushed
the
df_replace
branch
from
5f80862 to
4bc2753
Compare
| to_replace (str, regex, list, int, float or None): | ||
| How to find the values that will be replaced. | ||
|
|
||
| * numeric, str or regex: |
There was a problem hiding this comment.
I don't think the bulletpoint will be rendered correctly, we should get rid of it. Could you help do a staging following the instructions: https://screenshot.googleplex.com/5MQFPth8968Qjtw.
Just like: https://screenshot.googleplex.com/BPQxVeg7D7NjjTZ
There was a problem hiding this comment.
removed bullet points
There was a problem hiding this comment.
Not sure how the CloudRAD tool will render this. Will LGTM for this one, and we can check back if we need to re-format it.
| regex=False, | ||
| ): | ||
| """ | ||
| Replace values given in `to_replace` with `value`. |
There was a problem hiding this comment.
Could you also help add code_samples in the docs as well? Since the person who implements the method knows more about the use cases, and we don't need to do it later in a seperate PR.
There was a problem hiding this comment.
added a few code samples
|
|
||
|
|
||
| def is_patype(scalar: typing.Any, pa_type: pa.DataType) -> bool: | ||
| if pa_type == pa.time64("us"): |
There was a problem hiding this comment.
added docstring
product-auto-label
bot
added
size: l
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕