Skip to content
/ python-bigquery-dataframes Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix the DisplayOptions doc rendering #893

Merged
merged 1 commit into from
Aug 8, 2024
Merged

docs: fix the DisplayOptions doc rendering #893

merged 1 commit into from
Aug 8, 2024
+8 −0

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Aug 8, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary): Before: screenshot/9PL6mipmHHtg4x2, After: screenshot/BDLmQTTX8REjBpD

Fixes internal issue 358267007 🦕

@shobsi shobsi requested review from a team as code owners August 8, 2024 17:29
@shobsi shobsi requested a review from mattyopl August 8, 2024 17:29
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Aug 8, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Aug 8, 2024
@shobsi shobsi requested a review from chelsea-lin August 8, 2024 18:28
chelsea-lin
chelsea-lin approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a nit comment. Overall LGTM.

@shobsi shobsi merged commit 3eb6a17 into main Aug 8, 2024
22 of 23 checks passed
@shobsi shobsi deleted the shobs-docs-display-options branch August 8, 2024 19:03
@release-please release-please bot mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelsea-lin chelsea-lin

@mattyopl mattyopl

Assignees

@Genesis929 Genesis929

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shobsi @chelsea-lin @Genesis929