Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve guidance from snippet-bot #5058

Open
grayside opened this issue May 16, 2023 · 0 comments
Open

Improve guidance from snippet-bot #5058

grayside opened this issue May 16, 2023 · 0 comments
Assignees
Labels
bot: snippet-bot priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@grayside
Copy link

grayside commented May 16, 2023

Problem

snippet-bot provides guidance on the sample impact of pull requests.

However, this guidance provides a basic level of reporting that presumes deep subject-matter knowledge by the reader.

Screenshot showing snippet-bot message

Screenshot 2023-05-16 at 4 06 23 PM

Samples contributors less familiar with these details will either ignore this, or self-block until more details are available.

Proposal

  • Do not report moved region tags as sample browser page deletion
  • Clarify not just removing region tag, but removing region tag from known path is the problem
  • Clarify that moving region tag should be paused on docs coordination
@grayside grayside added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. bot: snippet-bot labels May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: snippet-bot priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants
@chingor13 @grayside and others