Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xDS load reporting is not populating total_issued_requests field in LRS reports #7538

Closed
dfawley opened this issue Aug 19, 2024 · 0 comments · Fixed by #7544
Closed

xDS load reporting is not populating total_issued_requests field in LRS reports #7538

dfawley opened this issue Aug 19, 2024 · 0 comments · Fixed by #7544
Assignees
@arjan-bal
Labels
Area: xDS Includes everything xDS related, including LB policies used with xDS. P1 Type: Bug
Milestone
1.67 Release

Comments

@dfawley
Copy link
Member

dfawley commented Aug 19, 2024

Looks like we did not ever populate this field, but the other gRPC languages are. The fields we should be setting are not specifically mentioned in gRFC A27 at this time, so we should also make sure to improve that gRFC.
@dfawley dfawley added this to the 1.67 Release milestone Aug 19, 2024
@arjan-bal arjan-bal self-assigned this Aug 21, 2024
@arjan-bal arjan-bal mentioned this issue Aug 21, 2024
Merged
@purnesh42H purnesh42H added the Area: xDS Includes everything xDS related, including LB policies used with xDS. label Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arjan-bal arjan-bal

Labels
Area: xDS Includes everything xDS related, including LB policies used with xDS. P1 Type: Bug
Projects
None yet
Milestone
1.67 Release
Development

Successfully merging a pull request may close this issue.

xdsclient: Populate total_issued_requests count in LRS load report arjan-bal/grpc-go
3 participants
@purnesh42H @dfawley @arjan-bal