Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is ghcide-bench supposed to be built and installed by default? #4359

Open
juhp opened this issue Jul 12, 2024 · 8 comments · May be fixed by #4376
Open

Is ghcide-bench supposed to be built and installed by default? #4359

juhp opened this issue Jul 12, 2024 · 8 comments · May be fixed by #4376
Labels
Hackage Anything to do with Hackage distributions of HLS type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@juhp
Copy link
Contributor

juhp commented Jul 12, 2024

Your environment

Which OS do you use? Fedora Linux

Which version of GHC do you use and how did you install it? ghc-9.4.5 from Fedora
How is your project built (alternative: link to the project)?
https://github.com/fedora-haskell/haskell-language-server

Which version of HLS do you use and how did you install it? 2.9.0

What's wrong?

bindir/ghcide-bench gets installed.
Is it intended for end users?

Debug information

https://download.copr.fedorainfracloud.org/results/petersen/haskell-language-server/fedora-rawhide-aarch64/07729207-haskell-language-server/builder-live.log.gz

@juhp juhp added status: needs triage type: support User support tickets, questions, help with setup etc. labels Jul 12, 2024
@juhp
Copy link
Contributor Author

juhp commented Jul 12, 2024

Perhaps I can just delete it? I should probably just have asked in matrix first,
but since I searched here I thought I would post the question...

@wz1000
Copy link
Collaborator

wz1000 commented Jul 12, 2024

No, it is an internal tool not needed by users.

@juhp
Copy link
Contributor Author

juhp commented Jul 12, 2024

So why is it built or rather how can I stop it?

@juhp
Copy link
Contributor Author

juhp commented Jul 12, 2024

I guess this is a bug report then :-)

@wz1000
Copy link
Collaborator

wz1000 commented Jul 12, 2024

The only executables you need are haskell-language-server and haskell-language-server-wrapper. I guess you just want to instruct your build system to build those explicitly.

@juhp
Copy link
Contributor Author

juhp commented Jul 12, 2024

I would still prefer if I could just cabal install and get the needed executables.
Couldn't the ghcide-bench executable be put behind a flag?
That feels the right thing to do?

@michaelpj
Copy link
Collaborator

I don't see any particular reason why we should insist on cabal install <package> doing what you want rather than cabal install <package>:<executable>?

@fendor fendor added type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. Hackage Anything to do with Hackage distributions of HLS and removed status: needs triage type: support User support tickets, questions, help with setup etc. labels Aug 6, 2024
@fendor
Copy link
Collaborator

fendor commented Aug 6, 2024

So, installing from hackage can (only?) be done via cabal install haskell-language-server which does build and install ghcide-bench executable.

In particular, you definitely can't run cabal install exe:haskell-language-server or cabal install haskell-language-server:exe:haskell-language-server.

That's indeed more annoying than necessary, imo.

I think it should be possible to disable ghcide-bench by default, but to allow cabal install exe:ghcide-bench without further configuration using an automatic cabal flag that's false by default. Doesn't seem to quite work as we want it to.

@fendor fendor linked a pull request Aug 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hackage Anything to do with Hackage distributions of HLS type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants