Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test discrepancies identified with kubetest2 - cloud-provider-gcp vs k/k #18865

Open
michaelmdresser opened this issue Aug 14, 2020 · 6 comments
Assignees
Labels
area/kubetest area/provider/gcp Issues or PRs related to gcp provider kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider.

Comments

@michaelmdresser
Copy link
Contributor

michaelmdresser commented Aug 14, 2020

What happened:
There are new CI jobs that use kubetest2 that are intended to serve as benchmarks to ensure parity of functionality between kubetest and kubetest2 before migrating more jobs from kubetest to kubetest2.

  1. ci-cloud-provider-gcp-conformance-latest is a periodic that runs the conformance E2E tests against cloud-provider-gcp using kubetest2.

  2. pull-kubernetes-e2e-gce-kubetest2 is a copy of pull-kubernetes-e2e-gce using kubetest2. This is the standard merge-blocking presubmit that runs on all PRs against k/k.

  3. ci-kubernetes-gce-conformance-latest-kubetest2 is a copy of ci-kubernetes-gce-conformance-latest using kubetest2. This is a periodic that runs conformance E2E tests against k/k.

Interesting behavior is being observed in TestGrid as 1 and 3 run. ci-cloud-provider-gcp-conformance-latest and ci-kubernetes-gce-conformance-latest-kubetest2 are essentially the same job - they both run conformance tests against a version of kubernetes (k/k vs cloud-provider-gcp) with kubetest2. However, comparing the dashboard for ci-kubernetes-gce-conformance-latest-kubetest2 with that of ci-cloud-provider-gcp-conformance-latest shows a striking difference. The easiest thing to point out is the set of AdmissionWebhook tests that succeed on ci-cloud-provider-gcp-conformance-latest yet fail on ci-kubernetes-gce-conformance-latest-kubetest2. Both tests use the latest version of kubetest2 and pull the latest available Ginkgo E2E test package. Kubetest2 calls (effectively) the same script in k/k and in cloud-provider-gcp to bring the cluster up, and it does so with the same set of environment variables.

The easy conclusion is that k/k has some regression or other difference when compared to cloud-provider-gcp. Yet, the original k/k conformance job ci-kubernetes-gce-conformance-latest has no failing tests.

What you expected to happen:
The same set of tests fail on ci-kubernetes-gce-conformance-latest as do on ci-cloud-provider-gcp-conformance-latest.

How to reproduce it (as minimally and precisely as possible):
N/A, see TestGrid.

Please provide links to example occurrences, if any:
See problem description.

@michaelmdresser michaelmdresser added the kind/bug Categorizes issue or PR as related to a bug. label Aug 14, 2020
@michaelmdresser
Copy link
Contributor Author

/cc @amwat

@amwat
Copy link
Contributor

amwat commented Aug 18, 2020

/cc @cheftako @cici37

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 26, 2020
@cheftako
Copy link
Member

cheftako commented Dec 4, 2020

/cc @jpbetz

@cheftako
Copy link
Member

cheftako commented Dec 4, 2020

/remove-lifecycle stale

@cheftako
Copy link
Member

cheftako commented Dec 4, 2020

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 4, 2020
@BenTheElder BenTheElder added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubetest area/provider/gcp Issues or PRs related to gcp provider kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider.
Projects
None yet
Development

No branches or pull requests

6 participants