Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Read Only #229133

Closed
Philanoe opened this issue Sep 20, 2024 · 1 comment
Closed

Ignore Read Only #229133

Philanoe opened this issue Sep 20, 2024 · 1 comment
Assignees

Comments

@Philanoe
Copy link

Type: Bug

Work on Debian 12, Xfce

Bug description :

  1. I opened a folder, modified a file.
  2. I changed the permission of a file into read only
  3. I was still able to modify and "save" the file within VS Code, with no error message.
  4. When I open the file from outside, I see that the file was not saved, whereas nothing told me so in VS Code.
  5. When I reopen VS code on the same folder, it enventually tells me that I cannot save the read only file.

Actual result

The following message is not printed 'Script_FallingStars.js': File is read-only. Select 'Overwrite' to attempt to make it writeable.

Expected result

The following message is printed : 'Script_FallingStars.js': File is read-only. Select 'Overwrite' to attempt to make it writeable.

Possible source of the problem :

VS Code might send a "read only" message based on a permission check done when we open a file. To solve this problem, VS Code should check the permission of the file each time a file is saved (at least for the manual saving operations) or be able to obtain and deal with the save error related to its saving command.

VS Code version: Code 1.93.1 (38c31bc, 2024-09-11T17:20:05.685Z)
OS version: Linux x64 6.1.0-25-amd64
Modes:

System Info
Item Value
Load (avg) 1, 1, 1
Process Argv . --crash-reporter-id b5f76845-0577-43fe-bc75-5b8127e903c1
Screen Reader no
VM 0%
DESKTOP_SESSION xfce
XDG_CURRENT_DESKTOP XFCE
XDG_SESSION_DESKTOP xfce
XDG_SESSION_TYPE x11
Extensions (1)
Extension Author (truncated) Version
JavaScriptSnippets xab 1.8.0
A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythongtdpath:30769146
welcomedialog:30910333
pythonnoceb:30805159
asynctok:30898717
pythonmypyd1:30879173
2e7ec940:31000449
pythontbext0:30879054
accentitlementst:30995554
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
g316j359:31013175
a69g1124:31058053
dvdeprecation:31068756
dwnewjupyter:31046869
2f103344:31071589
impr_priority:31102340
nativerepl1:31139838
refactort:31108082
pythonrstrctxt:31112756
flighttreat:31134774
wkspc-onlycs-t:31132770
wkspc-ranged-t:31125599
fje88620:31121564

@Philanoe
Copy link
Author

This behaviour does not appear again. I think I modified the writing rights of the wrong file. This issue can be closed.

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants