Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit f70ce7f

Browse files
committedJul 30, 2024
Auto merge of rust-lang#128234 - jcsp:retain-empty-case, r=tgross35
Optimize empty case in Vec::retain While profiling some code that happens to call Vec::retain() in a tight loop, I noticed more runtime than expected in retain, even in a bench case where the vector was always empty. When I wrapped my call to retain in `if !myvec.is_empty()` I saw faster execution compared with doing retain on an empty vector. On closer inspection, Vec::retain is doing set_len(0) on itself even when the vector is empty, and then resetting the length again in BackshiftOnDrop::drop. Unscientific screengrab of a flamegraph illustrating how we end up spending time in set_len and drop: ![image](https://github.com/user-attachments/assets/ebc72ace-84a0-4432-9b6f-1b3c96d353ba)
2 parents cc96f3e + 5d51099 commit f70ce7f

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed
 

‎alloc/src/vec/mod.rs

+6
Original file line numberDiff line numberDiff line change
@@ -1710,6 +1710,12 @@ impl<T, A: Allocator> Vec<T, A> {
17101710
F: FnMut(&mut T) -> bool,
17111711
{
17121712
let original_len = self.len();
1713+
1714+
if original_len == 0 {
1715+
// Empty case: explicit return allows better optimization, vs letting compiler infer it
1716+
return;
1717+
}
1718+
17131719
// Avoid double drop if the drop guard is not executed,
17141720
// since we may make some holes during the process.
17151721
unsafe { self.set_len(0) };

0 commit comments

Comments
 (0)
Failed to load comments.