Restore fetch of selected item in listboxes #10713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue in Chrome was resolved in version 77. It is now safe to re-enable fetching of selected items for listboxes. Original issue #9364
michaelDCurran
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Original issue #9364
And original fix
Chrome bug tracker: https://crbug.com/947898
Summary of the issue:
Due to #9364, fetching of selected item for list boxes was disabled. The issue in Chrome has been fixed since Version 77, we are now able to restore this functionality.
Description of how this pull request fixes the issue:
Remove Chrome specific code avoiding fetching selected items for listboxes.
Testing performed:
Followed STR from #9364.
Known issues with pull request:
Change log entry:
New features:
The currently selected item in listboxes is again presented in browse mode in Chrome, similar to NVDA 2019.1.