Detect Humanware Brailliant BI 40X and 20X via both USB and Bluetooth

[michaelDCurran]

Link to issue number:

None.

Summary of the issue:

Humanware BI 40X and 20X devices should be automatically detected via USB and Bluetooth.

Description of how this pull request fixes the issue:

Maps their respective USB IDs and Bluetooth names to our existing brailliantB driver.

Testing performed:

None - we don't have access to the devices, but we are informed these are compatible with the other Brailliant BI devices.

Known issues with pull request:

None.

Change log entry:

New features:

• NVDA will automatically detect the Humanware BI 40X and 20X devices via both USB and Bluetooth.

[LeonarddeR]

Do these devices also have serial support like the previous generation?

[michaelDCurran]

@LeonarddeR I don't know. I was not informed of that.

[LeonarddeR]

It might be worth asking for this explicitly, though I don't insist.

[feerrenrut]

This looks fine to me. If we could get explicit confirmation from someone that this works before the release, that would be great.

[AppVeyorBot]

• Build (for testing PR)
• System test failure

See test results for failed build of commit e212c4a0f3

[feerrenrut]

I can see the error in the system test, silly off by one error. New PR coming soon.

[lukaszgo1]

@michaelDCurran Diid you intent to merge this?

[LeonarddeR]

I think this should go in 2020.4 if possible.

[lukaszgo1]

@LeonarddeR Mint adding this to the 2020.4 milestone to avoid this being forgotten before the release?

[michaelDCurran]

There is some confusion remaining around whether these devices are released yet. I'm waiting on clarification from Humanware on what to do.

[feerrenrut]

There is some confusion remaining around whether these devices are released yet. I'm waiting on clarification from Humanware on what to do.

Is there any danger to including this in 2020.4 even if the devices aren't released yet?

[michaelDCurran]

The issue is more a marketing issue about it being announced widely in our documentation before Humanware did.

[dpy013]

hi @michaelDCurran
This branch has conflicts that must be resolved
Only those with
to this repository can merge pull requests.
Conflicting files
user_docs/en/changes.t2t
thanks

[michaelDCurran]

@feerrenrut I have retargetted this branch for beta now. Needs a review approval from you if you are happy. Humanware has confirmed this is oaky to go into NVDA 2020.4. Don't think they will provide us with any timely testing, nor we or anyone we know have access to one of those devices as they have not been released yet. However, the change is just adding extra mappings to more USB / Bluetooth IDs that use the same Humanware protocol.

[feerrenrut]

Looks good. Thanks @michaelDCurran.