Update liblouis to version 3.10 #9678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonarddeR
added
quick fix
component/liblouis
michaelDCurran
approved these changes
Jun 6, 2019
michaelDCurran
added a commit
that referenced
this pull request
Jun 6, 2019
LeonarddeR
pushed a commit
that referenced
this pull request
Aug 28, 2019
This reverts commit d5ed95c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
Liblouis 3.10.0 has been released.
Description of how this pull request fixes the issue:
Updated the liblouis submodule and changed the readme. While there are added/renamed/removed tables, they are not used by NVDA.
Version 3.10 is no longer free of warnings. As the liblouis team doesn't seem to care much about being warning free for VC++, I've lowered the warning level to level 2, in which case everything builds again. For this, I was inspired by the espeak sonscript. However, the espeak sconscript used env.Append instead of env.Replace. I changed the espeak sconscript as well to avoid a command line warning due to both /W3 and /W0 provided on the command line.
Testing performed:
Tested from source, everything worked as expected. Also, unit tests.
Known issues with pull request:
None
Change log entry: