Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license name for EPL-2.0 #784

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

netomi
Copy link
Contributor

@netomi netomi commented Oct 27, 2024

Resolves: python-poetry/poetry#9803

  • Added tests for changed code.
  • Updated documentation for changed code.

Test case was removed based on suggestion of @Secrus .

Not sure what documentation I should change in this regard, so I skip it for now, but let me know if I need to update something.

@dimbleby
Copy link
Contributor

the file you have change is autogenerated, you do not want to be changing that.

Maybe here

@netomi
Copy link
Contributor Author

netomi commented Oct 27, 2024

oh ty, will update the PR and try to understand how the json file got generated

@dimbleby
Copy link
Contributor

I dont think you need to care about the autogenerated file, just revert the change to it

@Secrus
Copy link
Member

Secrus commented Oct 27, 2024

From my short investigation, it might be as easy as adding that classifier to the dict here

@netomi netomi changed the title Update license names for EPL-1.0 and EPL-2.0 Update license name for EPL-2.0 Oct 27, 2024
@netomi
Copy link
Contributor Author

netomi commented Oct 27, 2024

yeah, updated my PR and force-pushed, ty guys.

tests/spdx/test_license.py Outdated Show resolved Hide resolved
netomi and others added 2 commits October 28, 2024 08:03
…lassifiers, add trove_classifier as test dependency, fix Aladdin license
@netomi
Copy link
Contributor Author

netomi commented Oct 28, 2024

Added a test case to ensure that all known licenses return a valid trove classifier.
While adding the test I figured that the Aladdin license was also failing, so fixed it right away.

@Secrus Secrus merged commit f688405 into python-poetry:main Oct 28, 2024
21 checks passed
@netomi netomi deleted the fix-epl-2_0-classifier branch October 28, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using License EPL-2.0 results in errors when publishing to pypi.org
3 participants