Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_flag_supported returns false negatives #1423

Open
RubixDev opened this issue Feb 27, 2025 · 1 comment · May be fixed by #1424
Open

is_flag_supported returns false negatives #1423

RubixDev opened this issue Feb 27, 2025 · 1 comment · May be fixed by #1424

Comments

@RubixDev
Copy link
Contributor

Seems like #892 is back. I once submitted a patch in #839 and that worked for me at the time, but after an update to cc v1.2.15 I'm having the same issues again. I'm on wasm32-unknown-unknown and using .flag_if_supported("-Wno-unused-parameter") doesn't add the flag even though it's supported.
@NobodyXu
Copy link
Collaborator

Hmmm is looks like the flag is removed.

NobodyXu added a commit that referenced this issue Feb 27, 2025
@NobodyXu
Fix wasm32-unknown-unknown by passing -c
a3fc3ae 
Fix #1423
@NobodyXu NobodyXu linked a pull request Feb 27, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wasm32-unknown-unknown by passing -c rust-lang/cc-rs
2 participants
@NobodyXu @RubixDev