Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit e601c8d

Browse files
committedJun 17, 2024
Migrate run-make/comment-section to rmake.rs
1 parent c349d08 commit e601c8d

File tree

3 files changed

+45
-19
lines changed

3 files changed

+45
-19
lines changed
 

‎src/tools/tidy/src/allowed_run_make_makefiles.txt

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ run-make/c-unwind-abi-catch-panic/Makefile
1111
run-make/cat-and-grep-sanity-check/Makefile
1212
run-make/cdylib-dylib-linkage/Makefile
1313
run-make/cdylib-fewer-symbols/Makefile
14-
run-make/comment-section/Makefile
1514
run-make/compiler-lookup-paths-2/Makefile
1615
run-make/compiler-lookup-paths/Makefile
1716
run-make/compiler-rt-works-on-mingw/Makefile

‎tests/run-make/comment-section/Makefile

-18
This file was deleted.
+45
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
// Both GCC and Clang write by default a `.comment` section with compiler information.
2+
// Rustc received a similar .comment section, so this tests checks that this section
3+
// properly appears.
4+
// See https://github.com/rust-lang/rust/commit/74b8d324eb77a8f337b35dc68ac91b0c2c06debc
5+
6+
//@ only-linux
7+
8+
use std::path::PathBuf;
9+
10+
use run_make_support::llvm_readobj;
11+
use run_make_support::rustc;
12+
use run_make_support::{cwd, env_var, read_dir, run_in_tmpdir};
13+
14+
fn main() {
15+
let target = env_var("TARGET");
16+
17+
rustc()
18+
.arg("-")
19+
.stdin("fn main() {}")
20+
.emit("link,obj")
21+
.arg("-Csave-temps")
22+
.target(&target)
23+
.run();
24+
25+
// Check linked output has a `.comment` section with the expected content.
26+
llvm_readobj()
27+
.section(".comment")
28+
.input("rust_out")
29+
.run()
30+
.assert_stdout_contains("rustc version 1.");
31+
32+
// Check all object files (including temporary outputs) have a `.comment`
33+
// section with the expected content.
34+
read_dir(cwd(), |f| {
35+
if !f.extension().is_some_and(|ext| ext == "o") {
36+
return;
37+
}
38+
39+
llvm_readobj()
40+
.section(".comment")
41+
.input(&f)
42+
.run()
43+
.assert_stdout_contains("rustc version 1.");
44+
});
45+
}

0 commit comments

Comments
 (0)
Failed to load comments.