Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for release notes of #130183: Bump Unicode to version 16.0.0 #130258

Open
3 tasks
rustbot opened this issue Sep 12, 2024 · 4 comments
Open
3 tasks
Labels
relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes.
Milestone

Comments

@rustbot
Copy link
Collaborator

rustbot commented Sep 12, 2024

This issue tracks the release notes text for #130183.

Steps

  • Proposed text is drafted by PR author (or team) making the noteworthy change.
  • Issue is nominated for release team review of clarity for wider audience.
  • Release team includes text in release notes/blog posts.

Release notes text

The responsible team for the underlying change should edit this section to replace the automatically generated link with a succinct description of what changed, drawing upon text proposed by the author (either in discussion or through direct editing).

# Libraries
- [Bump Unicode to version 16.0.0](https://github.com/rust-lang/rust/pull/130183)

Tip

Use the previous releases categories to help choose which one(s) to use.
The category will be de-duplicated with all the other ones by the release team.

More than one section can be included if needed.

Release blog section

If the change is notable enough for inclusion in the blog post, the responsible team should add content to this section.
Otherwise leave it empty.

cc @Marcondiro, @Manishearth -- origin issue/PR authors and assignees for starting to draft text

@rustbot rustbot added relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Sep 12, 2024
@rustbot rustbot added this to the 1.83.0 milestone Sep 12, 2024
@Noratrieb Noratrieb removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 12, 2024
@Noratrieb
Copy link
Member

we didn't have it in the blog post for 15, so I think that's it

@Mark-Simulacrum
Copy link
Member

We found a few regressions in Crater:

(Might actually be the same one)

Do we think a compat note is merited? Or just the library note is enough?

@Marcondiro
Copy link
Contributor

Might be worth it since crates embedding some Unicode Data (as the one you linked) could brake.

@pushrax
Copy link

pushrax commented Nov 5, 2024

I think a compat note is merited. Our application hit some errors after upgrading rustc, and it bisected to the unicode upgrade.

The reason is pretty niche; we're running a tokenizer to build bm25 text indexes, and the tokenization behaviour changed in some edge cases involving barely-valid utf8. But I could imagine that this might affect other similar use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes.
Projects
None yet
Development

No branches or pull requests

5 participants