Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Quick way to collapse all impl blocks #134429

Open
crumblingstatue opened this issue Dec 17, 2024 · 0 comments
Open

rustdoc: Quick way to collapse all impl blocks #134429

crumblingstatue opened this issue Dec 17, 2024 · 0 comments
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Comments

@crumblingstatue
Copy link
Contributor

The primary motivation of #130612 was to provide an easy way to overview the different kinds of impls on a type.
#132155 fulfills the layout aspect of the motivation, but there is no way (to my knowledge) to quickly collapse all impl blocks with one click.
The user has to manually click collapse on each one.
There should be a quick and convenient way to collapse (and expand) all the impl blocks to make it convenient to overview them.

The question is what would be the best way.
Here are some possibilities:

  1. Change the behavior of the summary button to also collapse impl blocks. Would this be desirable or annoying for users?
  2. Add another button. Would it clutter the UI too much?
  3. Add an alternate way to use the summary button. For example a shift+click could also collapse/expand impl blocks.
    A hover tooltip on the button could inform the user about this alternate usage.
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Dec 17, 2024
@jieyouxu jieyouxu added C-enhancement Category: An issue proposing an enhancement or a PR with one. A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Development

No branches or pull requests

3 participants