Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crater run for unit_bindings #136882

Closed
jieyouxu opened this issue Feb 11, 2025 · 5 comments
Closed

Crater run for unit_bindings #136882

jieyouxu opened this issue Feb 11, 2025 · 5 comments
Assignees
@jieyouxu
Labels
C-crater Category: Issue for tracking crater runs L-unit_bindings Lint: unit_bindings

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Feb 11, 2025 •
edited
Loading

Wanted to see how many crates might be affected if we start to warn on unit_bindings.

Praying to craterbot that I can find the right incantation 🙏
@rustbot rustbot added needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. L-unit_bindings Lint: unit_bindings labels Feb 11, 2025
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Feb 11, 2025
@jieyouxu
Copy link
Member Author

@craterbot run name=warn_on_unit_bindings_1 mode=check-only start=nightly-2025-02-10 end=nightly-2025-02-10+rustflags=-Dunit_bindings

@craterbot
Copy link
Collaborator

👌 Experiment warn_on_unit_bindings_1 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Feb 11, 2025
@craterbot
Copy link
Collaborator

🚧 Experiment warn_on_unit_bindings_1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment warn_on_unit_bindings_1 is completed!
📊 3669 regressed and 9 fixed (581552 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Feb 12, 2025
@jieyouxu jieyouxu removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 12, 2025
@jieyouxu jieyouxu self-assigned this Feb 12, 2025
@workingjubilee workingjubilee added the C-crater Category: Issue for tracking crater runs label Feb 14, 2025
@jieyouxu
Copy link
Member Author

Closing as even a cursory glance suggests to me that if we do warn on this by default, it probably needs to be over an edition boundary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jieyouxu jieyouxu

Labels
C-crater Category: Issue for tracking crater runs L-unit_bindings Lint: unit_bindings
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jieyouxu @craterbot @workingjubilee @rustbot