Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc::clean::types::Type::is_doc_subtype_of has outdated example, and arguments are flipped #138572

Open
lolbinarycat opened this issue Mar 16, 2025 · 0 comments
Open

rustdoc::clean::types::Type::is_doc_subtype_of has outdated example, and arguments are flipped #138572

lolbinarycat opened this issue Mar 16, 2025 · 0 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@lolbinarycat
Copy link
Contributor

it seems weird (and likely a mistake) to say T is a subtype of u8. the example refers to the function as is_same, so perhaps the name was changed without thinking if the semantics make sense?
@lolbinarycat lolbinarycat added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 16, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lolbinarycat @rustbot