Tracking issue for release notes of #138233: Windows: Don't link std (and run-make) against advapi32, except on win7

[rustbot]

This issue tracks the release notes text for #138233.

cc @smmalis37, @ChrisDenton -- original issue/PR authors and assignees for drafting text

See the forge.rust-lang.org chapter about release notes for an overview of how the release team makes use of these tracking issues.

Release notes text

This section should be edited to specify the correct category(s) for the change, with succinct description(s) of what changed. Some things worth considering:

• Does this need an additional compat notes section?
• Was this a libs stabilization that should have additional headers to list new APIs under Stabilized APIs and Const Stabilized APIs?

# Compatibility Notes
- [Windows: The standard library no longer links advapi32, except on win7.](https://github.com/rust-lang/rust/pull/138233) Code such as C libraries that were relying on this assumption may need to explicitly link advapi32.

Tip

Use the previous releases for inspiration on how to write the release notes text and which categories to pick.

Release blog section

If this change is notable enough for inclusion in the blog post then this section should be edited to contain a draft for the blog post. Otherwise leave it empty.

Note

If a blog post section is required the release-blog-post label should be added (@rustbot label +release-blog-post) to this issue as otherwise it may be missed by the release team.

[ChrisDenton]

Does this require a relnote?

[smalis-msft]

I don't think so. The std library already wasn't depending on any functionality in advapi32, the PR just removed it from the list of available libs linked against.

[ehuss]

I have marked this as relnotes because it caused a regression in git2. libgit2's C code was using some functions from advapi32, but the build script failed to include it explicitly (it was relying on the implicit inclusion from the standard library). I think that's the fault of git2's script, but it caused a regression nonetheless.

[smalis-msft]

Oh interesting. I wouldn't have expected that, but good to know, and I hope it was an easy fix. In that case then maybe this is worth mentioning yeah.