Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vh and vw units #138

Closed
Sharcoux opened this issue Apr 2, 2020 · 5 comments
Closed

Support vh and vw units #138

Sharcoux opened this issue Apr 2, 2020 · 5 comments

Comments

@Sharcoux
Copy link

Sharcoux commented Apr 2, 2020

Hi,

I think we should be able to support vh and vw units by replacing Xvh by X * Dimensions.get('window').height / 100 and Xvw by X * Dimensions.get('window').width / 100, can't we?

@Sharcoux
Copy link
Author

Sharcoux commented Apr 2, 2020

@jacobp100
Copy link
Contributor

I'm guessing this issue more asking for vw/vh support in styled components. There's not much this library can do to add support there - it's up to styled components to add support for it in their runtime

My styled-components clone supports it (https://jacobp100.github.io/cssta/css-support/) - so it is definitely possible for support to be added!

I'll close this issue as there's nothing we can do here to support it, but feel free to continue the discussion or ask any other questions

@Sharcoux
Copy link
Author

Sharcoux commented Apr 2, 2020

Oh, sorry then, I thought it was the right project to target. Ok, I'll move it there.

@jacobp100
Copy link
Contributor

There’s probably an issue already. It’s a common feature request

@Sharcoux
Copy link
Author

Sharcoux commented Apr 2, 2020

Yeah, I found it. Seems on stand by for now. I'll try to understand exactly how it should be done, see if I can give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants